doc: explain native external types #31214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: nodejs#31173 (comment)
nodejs-github-bot
added
doc
4 tasks
jasnell
reviewed
Jan 6, 2020
BridgeAR
approved these changes
Jan 7, 2020
BridgeAR
added
the
author ready
Trott
reviewed
Jan 7, 2020
Trott
reviewed
Jan 7, 2020
Trott
approved these changes
Jan 7, 2020
cjihrig
approved these changes
Jan 8, 2020
gireeshpunathil
approved these changes
Jan 8, 2020
|
rebuild Ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4122 |
gireeshpunathil
pushed a commit
that referenced
this pull request
Jan 8, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
@gireeshpunathil These commits just got pushed to master as-is. |
|
@mscdex - saw the mistake, corrected it now. thanks! |
|
landed in 95871a1 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
There is a reference to native external types in util.types.isExternal api documentation. Provide a brief explanation to that. Refs: #31173 (comment) PR-URL: #31214 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes